Upgrade to ocamlformat 0.26.0 #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
force-pushed
the
preview-ocamlformat-0.26.0
branch
from
091e6f1
to
b2a0408
Compare
Julow
force-pushed
the
preview-ocamlformat-0.26.0
branch
2 times, most recently
from
db51951
to
5992a15
Compare
Julow
changed the title
Signed-off-by: Jules Aguillon <[email protected]>
Signed-off-by: Jules Aguillon <[email protected]>
Julow
force-pushed
the
preview-ocamlformat-0.26.0
branch
from
5992a15
to
f1d5bd7
Compare
|
OCamlformat 0.26.0 has been released! This PR can be merged (not squashed due to |
|
OCamlformat will be released with compatibility with 5.1 in a few weeks. Let's skip 0.26.0. Should I open a similar PR for future versions ? |
|
Sorry for not answering earlier... I am personally in favour of upgrading ocamlformat, so I would welcome a similar PR! Being able to give feedback on changes that affect our codebase is also valuable. I don't know what other maintainers think, though. |
|
I'll create a similar PR next time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unnecessary escaping is removed from doc-comments, which has a huge impact on
ast.ml. The indentation of attributes after alet/valis also changed, which are present in an unusual amount in ppxlib ! The class are more compact.The aim of this commit is to gather feedback.
Changelog can be found here: https://github.com/ocaml-ppx/ocamlformat/blob/main/CHANGES.md